Summary

Update SCMClients and tests for the new diff dictionary change.

Review Request #4423 — Created Aug. 12, 2013 and submitted Aug. 12, 2013, 4:52 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

release-0.5.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Update SCMClients and tests for the new diff dictionary change.

My recent change to convert diff results to a dictionary that also
introduced the base_commit_id value was pushed prematurely. This change
finishes that up by updating all other SCMClients, post-review, and unit
tests.

Testing Done

Unit tests passed. Well, mostly. Some were already broken, but the
ones that were working before work now.

Tested that post-review now works.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	Aug. 12, 2013, 4:51 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbtools/clients/cvs.py
    rbtools/postreview.py
    rbtools/clients/tests.py
    rbtools/clients/clearcase.py
    rbtools/clients/plastic.py
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/perforce.py
    rbtools/clients/bazaar.py
    rbtools/clients/svn.py
  Ignored Files:

rbtools/clients/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    rbtools/clients/cvs.py
    rbtools/postreview.py
    rbtools/clients/tests.py
    rbtools/clients/clearcase.py
    rbtools/clients/plastic.py
    rbtools/clients/__init__.py
    rbtools/clients/mercurial.py
    rbtools/clients/perforce.py
    rbtools/clients/bazaar.py
    rbtools/clients/svn.py
  Ignored Files:

Ship it!

```
Ship It!
```

Review Board 7.0 alpha 0 (dev)

Update SCMClients and tests for the new diff dictionary change.

Information

Reviewers

Status: Closed (submitted)

rbtools/clients/tests.py (Diff revision 1)