Summary

Added full home directory to subversion certificate error message.

Review Request #442 — Created July 8, 2008 and submitted

Information

Owner

schapht

Repository

Review Board SVN (deprecated)

Branch

trunk

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The previous message just said '~'.  This substitutes the actual home directory of the user which should be helpful when diagnosing svn issues.

Testing Done

scmtools tests still run (os x, linux).  Used this change to help diagnose confusion about which user reviewboard was running as.

/trunk/reviewboard/scmtools/svn.py (Diff revision 1)

We should probably figure out what our story is for running this on Windows. This and the path mentioned may very well be wrong.

schapht July 10, 2008, 10:11 p.m.

Good point.  I think os.path.expanduser('~') might be the better choice here anyway.  I'll try it out on Mac and Windows then update the diff.

/trunk/reviewboard/scmtools/svn.py (Diff revision 1)

Rather than special-casing this line, remove the "+" on each line (as Python will properly concatenate the strings) and then put the "% home" at the end of the whole string. (Home doesn't need to be in parens).

SC

schapht July 10, 2008, 10:11 p.m.
```
Will do.
```

Updated diff.  I attempted to write a unit test for this, but it looks like the subversion get_file test doesn't run correctly on windows yet.

/trunk/reviewboard/scmtools/svn.py (Diff revision 2)

On my XP image this resolves as follows:

>>> os.path.expanduser('~')
'C:\\Documents and Settings\\Administrator'

Ship it!

```
Looks good. Committed as r1412. Thanks!
```