Add support for Beanstalk as a hosting service.
Review Request #4417 — Created Aug. 10, 2013 and submitted
Add support for Beanstalk as a hosting service. This supports both Git and Subversion repositories on Beanstalk. It makes use of the new base_commit_id support and hosting service repository validation. Unit tests were added for all the new functionality.
Linked up Subversion and Git repositories on Beanstalk. Verified repositories and posted patches using the new support in RBTools.
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: setup.py reviewboard/hostingsvcs/beanstalk.py reviewboard/scmtools/crypto.py Ignored Files:
-
Can you add docstrings for the public methods?
-
reviewboard/hostingsvcs/beanstalk.py (Diff revision 1) How about just importing URLError and HTTPError, since that's all we use?
Change Summary:
* Added documentation to public methods. * Provided a useful error when trying to fetch a file using Git without having a base commit ID. * Allowed fetching files without a base commit ID for Subversion. * Added unit tests. * Made urllib2 imports more specific.
Description: |
|
|||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+432 -2) |
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: setup.py reviewboard/hostingsvcs/beanstalk.py reviewboard/scmtools/crypto.py reviewboard/hostingsvcs/tests.py Ignored Files: -
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: setup.py reviewboard/hostingsvcs/beanstalk.py reviewboard/scmtools/crypto.py Ignored Files: