Add support for Beanstalk as a hosting service.

Review Request #4417 — Created Aug. 10, 2013 and submitted

Information

Review Board
release-1.7.x

Reviewers

Add support for Beanstalk as a hosting service.

This supports both Git and Subversion repositories on Beanstalk. It
makes use of the new base_commit_id support and hosting service
repository validation.

Unit tests were added for all the new functionality.
Linked up Subversion and Git repositories on Beanstalk. Verified
repositories and posted patches using the new support in RBTools.
Description From Last Updated

How about just importing URLError and HTTPError, since that's all we use?

daviddavid

Col: 80 E501 line too long (82 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (82 > 79 characters)

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        setup.py
        reviewboard/hostingsvcs/beanstalk.py
        reviewboard/scmtools/crypto.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        setup.py
        reviewboard/hostingsvcs/beanstalk.py
        reviewboard/scmtools/crypto.py
      Ignored Files:
    
    
  2. 
      
david
  1. Can you add docstrings for the public methods?
  2. reviewboard/hostingsvcs/beanstalk.py (Diff revision 1)
     
     
    Show all issues
    How about just importing URLError and HTTPError, since that's all we use?
  3. 
      
chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        setup.py
        reviewboard/hostingsvcs/beanstalk.py
        reviewboard/scmtools/crypto.py
        reviewboard/hostingsvcs/tests.py
      Ignored Files:
    
    
  2. reviewboard/hostingsvcs/tests.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (82 > 79 characters)
    
  3. reviewboard/hostingsvcs/tests.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (82 > 79 characters)
    
  4. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        setup.py
        reviewboard/hostingsvcs/beanstalk.py
        reviewboard/scmtools/crypto.py
        reviewboard/hostingsvcs/tests.py
      Ignored Files:
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed