Summary

Add support for Beanstalk as a hosting service.

Review Request #4417 — Created Aug. 10, 2013 and submitted Aug. 12, 2013, 11:40 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-1.7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Add support for Beanstalk as a hosting service.

This supports both Git and Subversion repositories on Beanstalk. It
makes use of the new base_commit_id support and hosting service
repository validation.

Unit tests were added for all the new functionality.

Testing Done

Linked up Subversion and Git repositories on Beanstalk. Verified
repositories and posted patches using the new support in RBTools.

Issues

Description	From	Last Updated
How about just importing URLError and HTTPError, since that's all we use?	david	Aug. 11, 2013, 3:59 p.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	Aug. 11, 2013, 4:12 p.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	Aug. 11, 2013, 4:12 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    setup.py
    reviewboard/hostingsvcs/beanstalk.py
    reviewboard/scmtools/crypto.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    setup.py
    reviewboard/hostingsvcs/beanstalk.py
    reviewboard/scmtools/crypto.py
  Ignored Files:

Can you add docstrings for the public methods?

reviewboard/hostingsvcs/beanstalk.py (Diff revision 1)
The issue has been resolved. Show all issues
```
How about just importing URLError and HTTPError, since that's all we use?
```

Change Summary:

* Added documentation to public methods.
* Provided a useful error when trying to fetch a file using Git without having a base commit ID.
* Allowed fetching files without a base commit ID for Subversion.
* Added unit tests.
* Made urllib2 imports more specific.

Description:

		Add support for Beanstalk as a hosting service.

		This supports both Git and Subversion repositories on Beanstalk. It
		makes use of the new base_commit_id support and hosting service
		repository validation.
	+
	+	Unit tests were added for all the new functionality.

Diff:

Revision 2 (+432 -2)

Show changes

	setup.py
	reviewboard/hostingsvcs/beanstalk.py
	reviewboard/hostingsvcs/tests.py
	reviewboard/scmtools/crypto.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    setup.py
    reviewboard/hostingsvcs/beanstalk.py
    reviewboard/scmtools/crypto.py
    reviewboard/hostingsvcs/tests.py
  Ignored Files:

reviewboard/hostingsvcs/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
reviewboard/hostingsvcs/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    setup.py
    reviewboard/hostingsvcs/beanstalk.py
    reviewboard/scmtools/crypto.py
    reviewboard/hostingsvcs/tests.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed