Fix PEP-8 issues in accounts/ and admin/
Review Request #4412 — Created Aug. 9, 2013 and submitted
Fix PEP-8 issues in accounts/ and admin/ This change fixes up most of the issues found by the pep8 tool. The ones that I left where where we had mapping tables that were formatted for readability.
Description | From | Last Updated |
---|---|---|
Col: 80 E501 line too long (80 > 79 characters) |
![]() |
|
'InvalidCacheBackendError' imported but unused |
![]() |
|
'parse_backend_uri' imported but unused |
![]() |
|
Col: 80 E501 line too long (80 > 79 characters) |
![]() |
|
Can we put the label= on their own lines? |
|
|
This is pep-8-complaint, but it still feels so inconsistent with other uses of patterns(). Mixed feelings, but I'm okay with … |
|
|
Would parens have solved this and let us have the extra breathing room for text? |
|
|
This is one I don't like. What does it say about this? I'd much, much prefer we violate pep-8 if … |
|
|
Same comments about the urlpatterns in this file. |
|
![reviewbot](https://reviews.reviewboard.org/static/ext/reviewbotext.extension.ReviewBotExtension/images/reviewbot.png)
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/admin/checks.py reviewboard/admin/forms.py reviewboard/admin/management/commands/dumpdb.py reviewboard/admin/siteconfig.py reviewboard/admin/views.py reviewboard/accounts/backends.py reviewboard/admin/templatetags/rbadmintags.py reviewboard/accounts/views.py reviewboard/accounts/urls.py reviewboard/admin/urls.py reviewboard/admin/management/sites.py reviewboard/accounts/models.py reviewboard/admin/widgets.py reviewboard/admin/cache_stats.py reviewboard/accounts/admin.py reviewboard/admin/middleware.py reviewboard/accounts/forms.py Ignored Files:
-
-
![reviewbot](https://reviews.reviewboard.org/static/ext/reviewbotext.extension.ReviewBotExtension/images/reviewbot.png)
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/admin/checks.py reviewboard/admin/forms.py reviewboard/admin/management/commands/dumpdb.py reviewboard/admin/siteconfig.py reviewboard/admin/views.py reviewboard/accounts/backends.py reviewboard/admin/templatetags/rbadmintags.py reviewboard/accounts/views.py reviewboard/accounts/urls.py reviewboard/admin/urls.py reviewboard/admin/management/sites.py reviewboard/accounts/models.py reviewboard/admin/widgets.py reviewboard/admin/cache_stats.py reviewboard/accounts/admin.py reviewboard/admin/middleware.py reviewboard/accounts/forms.py Ignored Files:
-
![reviewbot](https://reviews.reviewboard.org/static/ext/reviewbotext.extension.ReviewBotExtension/images/reviewbot.png)
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/admin/checks.py reviewboard/admin/forms.py reviewboard/admin/management/commands/dumpdb.py reviewboard/admin/siteconfig.py reviewboard/admin/views.py reviewboard/accounts/backends.py reviewboard/admin/templatetags/rbadmintags.py reviewboard/accounts/views.py reviewboard/accounts/urls.py reviewboard/admin/urls.py reviewboard/admin/management/sites.py reviewboard/accounts/models.py reviewboard/admin/widgets.py reviewboard/admin/cache_stats.py reviewboard/accounts/admin.py reviewboard/admin/middleware.py reviewboard/accounts/forms.py Ignored Files:
![reviewbot](https://reviews.reviewboard.org/static/ext/reviewbotext.extension.ReviewBotExtension/images/reviewbot.png)
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/admin/checks.py reviewboard/admin/forms.py reviewboard/admin/management/commands/dumpdb.py reviewboard/admin/siteconfig.py reviewboard/admin/views.py reviewboard/accounts/backends.py reviewboard/admin/templatetags/rbadmintags.py reviewboard/accounts/views.py reviewboard/accounts/urls.py reviewboard/admin/urls.py reviewboard/admin/management/sites.py reviewboard/accounts/models.py reviewboard/admin/widgets.py reviewboard/admin/cache_stats.py reviewboard/accounts/admin.py reviewboard/admin/middleware.py reviewboard/accounts/forms.py Ignored Files:
![reviewbot](https://reviews.reviewboard.org/static/ext/reviewbotext.extension.ReviewBotExtension/images/reviewbot.png)
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/admin/checks.py reviewboard/admin/forms.py reviewboard/admin/management/commands/dumpdb.py reviewboard/admin/siteconfig.py reviewboard/admin/views.py reviewboard/accounts/backends.py reviewboard/admin/templatetags/rbadmintags.py reviewboard/accounts/views.py reviewboard/accounts/urls.py reviewboard/admin/urls.py reviewboard/admin/management/sites.py reviewboard/accounts/models.py reviewboard/admin/widgets.py reviewboard/admin/cache_stats.py reviewboard/accounts/admin.py reviewboard/admin/middleware.py reviewboard/accounts/forms.py Ignored Files:
-
-
I think I'll just need to get used to this, but do we want to say now that this is the official method for all multi-line imports now?
-
-
-
This is pep-8-complaint, but it still feels so inconsistent with other uses of patterns(). Mixed feelings, but I'm okay with this. However, can we have a blank line between this parameter and the urls, to help separate things out?
-
-
This is one I don't like. What does it say about this? I'd much, much prefer we violate pep-8 if this is the case. When there's multiple things in the context dictionary, it'll have to be multi-line anyway, and I think consistency is important.
![reviewbot](https://reviews.reviewboard.org/static/ext/reviewbotext.extension.ReviewBotExtension/images/reviewbot.png)
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/admin/checks.py reviewboard/admin/forms.py reviewboard/admin/management/commands/dumpdb.py reviewboard/admin/siteconfig.py reviewboard/admin/views.py reviewboard/accounts/backends.py reviewboard/admin/templatetags/rbadmintags.py reviewboard/accounts/views.py reviewboard/accounts/urls.py reviewboard/admin/urls.py reviewboard/admin/management/sites.py reviewboard/accounts/models.py reviewboard/admin/widgets.py reviewboard/admin/cache_stats.py reviewboard/accounts/admin.py reviewboard/admin/middleware.py reviewboard/accounts/forms.py Ignored Files:
![reviewbot](https://reviews.reviewboard.org/static/ext/reviewbotext.extension.ReviewBotExtension/images/reviewbot.png)
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/admin/checks.py reviewboard/admin/forms.py reviewboard/admin/management/commands/dumpdb.py reviewboard/admin/siteconfig.py reviewboard/admin/views.py reviewboard/accounts/backends.py reviewboard/admin/templatetags/rbadmintags.py reviewboard/accounts/views.py reviewboard/accounts/urls.py reviewboard/admin/urls.py reviewboard/admin/management/sites.py reviewboard/accounts/models.py reviewboard/admin/widgets.py reviewboard/admin/cache_stats.py reviewboard/accounts/admin.py reviewboard/admin/middleware.py reviewboard/accounts/forms.py Ignored Files:
![reviewbot](https://reviews.reviewboard.org/static/ext/reviewbotext.extension.ReviewBotExtension/images/reviewbot.png)
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/admin/checks.py reviewboard/admin/forms.py reviewboard/admin/management/commands/dumpdb.py reviewboard/admin/siteconfig.py reviewboard/admin/views.py reviewboard/accounts/backends.py reviewboard/admin/templatetags/rbadmintags.py reviewboard/accounts/evolutions/timezone.py reviewboard/accounts/urls.py reviewboard/admin/urls.py reviewboard/admin/management/sites.py reviewboard/accounts/models.py reviewboard/admin/widgets.py reviewboard/admin/cache_stats.py reviewboard/accounts/admin.py reviewboard/accounts/views.py reviewboard/admin/middleware.py reviewboard/accounts/forms.py Ignored Files:
![reviewbot](https://reviews.reviewboard.org/static/ext/reviewbotext.extension.ReviewBotExtension/images/reviewbot.png)
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/admin/checks.py reviewboard/admin/forms.py reviewboard/admin/management/commands/dumpdb.py reviewboard/admin/siteconfig.py reviewboard/admin/views.py reviewboard/accounts/backends.py reviewboard/admin/templatetags/rbadmintags.py reviewboard/accounts/evolutions/timezone.py reviewboard/accounts/urls.py reviewboard/admin/urls.py reviewboard/admin/management/sites.py reviewboard/accounts/models.py reviewboard/admin/widgets.py reviewboard/admin/cache_stats.py reviewboard/accounts/admin.py reviewboard/accounts/views.py reviewboard/admin/middleware.py reviewboard/accounts/forms.py Ignored Files: