Summary

Fix PEP-8 issues in accounts/ and admin/

Review Request #4412 — Created Aug. 9, 2013 and submitted Aug. 11, 2013, 7:10 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix PEP-8 issues in accounts/ and admin/

This change fixes up most of the issues found by the pep8 tool. The ones that I
left where where we had mapping tables that were formatted for readability.

Testing Done

Issues

Description	From	Last Updated
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Aug. 9, 2013, 7:40 p.m.
'InvalidCacheBackendError' imported but unused	reviewbot	Aug. 9, 2013, 7:41 p.m.
'parse_backend_uri' imported but unused	reviewbot	Aug. 9, 2013, 7:41 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Aug. 9, 2013, 7:43 p.m.
Can we put the label= on their own lines?	chipx86	Aug. 10, 2013, 8:45 p.m.
This is pep-8-complaint, but it still feels so inconsistent with other uses of patterns(). Mixed feelings, but I'm okay with …	chipx86	Aug. 10, 2013, 8:50 p.m.
Would parens have solved this and let us have the extra breathing room for text?	chipx86	Aug. 10, 2013, 8:51 p.m.
This is one I don't like. What does it say about this? I'd much, much prefer we violate pep-8 if …	chipx86	Aug. 10, 2013, 8:52 p.m.
Same comments about the urlpatterns in this file.	chipx86	Aug. 11, 2013, 7:09 a.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/forms.py
    reviewboard/admin/management/commands/dumpdb.py
    reviewboard/admin/siteconfig.py
    reviewboard/admin/views.py
    reviewboard/accounts/backends.py
    reviewboard/admin/templatetags/rbadmintags.py
    reviewboard/accounts/views.py
    reviewboard/accounts/urls.py
    reviewboard/admin/urls.py
    reviewboard/admin/management/sites.py
    reviewboard/accounts/models.py
    reviewboard/admin/widgets.py
    reviewboard/admin/cache_stats.py
    reviewboard/accounts/admin.py
    reviewboard/admin/middleware.py
    reviewboard/accounts/forms.py
  Ignored Files:

reviewboard/accounts/backends.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/forms.py
    reviewboard/admin/management/commands/dumpdb.py
    reviewboard/admin/siteconfig.py
    reviewboard/admin/views.py
    reviewboard/accounts/backends.py
    reviewboard/admin/templatetags/rbadmintags.py
    reviewboard/accounts/views.py
    reviewboard/accounts/urls.py
    reviewboard/admin/urls.py
    reviewboard/admin/management/sites.py
    reviewboard/accounts/models.py
    reviewboard/admin/widgets.py
    reviewboard/admin/cache_stats.py
    reviewboard/accounts/admin.py
    reviewboard/admin/middleware.py
    reviewboard/accounts/forms.py
  Ignored Files:

reviewboard/admin/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'InvalidCacheBackendError' imported but unused
```
reviewboard/admin/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'parse_backend_uri' imported but unused
```

Diff:

Revision 2 (+168 -184)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/backends.py
	reviewboard/accounts/forms.py
	reviewboard/accounts/models.py
	reviewboard/accounts/urls.py
	reviewboard/accounts/views.py
	reviewboard/admin/cache_stats.py
	reviewboard/admin/checks.py
	9 more

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/forms.py
    reviewboard/admin/management/commands/dumpdb.py
    reviewboard/admin/siteconfig.py
    reviewboard/admin/views.py
    reviewboard/accounts/backends.py
    reviewboard/admin/templatetags/rbadmintags.py
    reviewboard/accounts/views.py
    reviewboard/accounts/urls.py
    reviewboard/admin/urls.py
    reviewboard/admin/management/sites.py
    reviewboard/accounts/models.py
    reviewboard/admin/widgets.py
    reviewboard/admin/cache_stats.py
    reviewboard/accounts/admin.py
    reviewboard/admin/middleware.py
    reviewboard/accounts/forms.py
  Ignored Files:

reviewboard/accounts/backends.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/forms.py
    reviewboard/admin/management/commands/dumpdb.py
    reviewboard/admin/siteconfig.py
    reviewboard/admin/views.py
    reviewboard/accounts/backends.py
    reviewboard/admin/templatetags/rbadmintags.py
    reviewboard/accounts/views.py
    reviewboard/accounts/urls.py
    reviewboard/admin/urls.py
    reviewboard/admin/management/sites.py
    reviewboard/accounts/models.py
    reviewboard/admin/widgets.py
    reviewboard/admin/cache_stats.py
    reviewboard/accounts/admin.py
    reviewboard/admin/middleware.py
    reviewboard/accounts/forms.py
  Ignored Files:

Diff:

Revision 3 (+168 -183)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/backends.py
	reviewboard/accounts/forms.py
	reviewboard/accounts/models.py
	reviewboard/accounts/urls.py
	reviewboard/accounts/views.py
	reviewboard/admin/cache_stats.py
	reviewboard/admin/checks.py
	9 more

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/forms.py
    reviewboard/admin/management/commands/dumpdb.py
    reviewboard/admin/siteconfig.py
    reviewboard/admin/views.py
    reviewboard/accounts/backends.py
    reviewboard/admin/templatetags/rbadmintags.py
    reviewboard/accounts/views.py
    reviewboard/accounts/urls.py
    reviewboard/admin/urls.py
    reviewboard/admin/management/sites.py
    reviewboard/accounts/models.py
    reviewboard/admin/widgets.py
    reviewboard/admin/cache_stats.py
    reviewboard/accounts/admin.py
    reviewboard/admin/middleware.py
    reviewboard/accounts/forms.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/forms.py
    reviewboard/admin/management/commands/dumpdb.py
    reviewboard/admin/siteconfig.py
    reviewboard/admin/views.py
    reviewboard/accounts/backends.py
    reviewboard/admin/templatetags/rbadmintags.py
    reviewboard/accounts/views.py
    reviewboard/accounts/urls.py
    reviewboard/admin/urls.py
    reviewboard/admin/management/sites.py
    reviewboard/accounts/models.py
    reviewboard/admin/widgets.py
    reviewboard/admin/cache_stats.py
    reviewboard/accounts/admin.py
    reviewboard/admin/middleware.py
    reviewboard/accounts/forms.py
  Ignored Files:

reviewboard/accounts/admin.py (Diff revision 3)

I think I'll just need to get used to this, but do we want to say now that this is the official method for all multi-line imports now?

david Aug. 10, 2013, 8:52 p.m.
```
Yes, I think so.
```

reviewboard/accounts/forms.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Can we put the label= on their own lines?
```

reviewboard/accounts/forms.py (Diff revision 3)

Do you know if the tool would be happy doing:

_(.....
  .....)
% {
    ...
}

david Aug. 10, 2013, 8:52 p.m.
```
Yeah, that works.
```

reviewboard/accounts/urls.py (Diff revision 3)

The issue has been resolved. Show all issues

This is pep-8-complaint, but it still feels so inconsistent with other uses of patterns(). Mixed feelings, but I'm okay with this. However, can we have a blank line between this parameter and the urls, to help separate things out?

reviewboard/admin/forms.py (Diff revision 3)

The issue has been resolved. Show all issues

Would parens have solved this and let us have the extra breathing room for text?

reviewboard/admin/widgets.py (Diff revision 3)

The issue has been resolved. Show all issues

This is one I don't like. What does it say about this?

I'd much, much prefer we violate pep-8 if this is the case. When there's multiple things in the context dictionary, it'll have to be multi-line anyway, and I think consistency is important.

david Aug. 10, 2013, 8:52 p.m.

It complained about the relative alignment of { and }.

Diff:

Revision 4 (+168 -183)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/backends.py
	reviewboard/accounts/forms.py
	reviewboard/accounts/models.py
	reviewboard/accounts/urls.py
	reviewboard/accounts/views.py
	reviewboard/admin/cache_stats.py
	reviewboard/admin/checks.py
	9 more

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/forms.py
    reviewboard/admin/management/commands/dumpdb.py
    reviewboard/admin/siteconfig.py
    reviewboard/admin/views.py
    reviewboard/accounts/backends.py
    reviewboard/admin/templatetags/rbadmintags.py
    reviewboard/accounts/views.py
    reviewboard/accounts/urls.py
    reviewboard/admin/urls.py
    reviewboard/admin/management/sites.py
    reviewboard/accounts/models.py
    reviewboard/admin/widgets.py
    reviewboard/admin/cache_stats.py
    reviewboard/accounts/admin.py
    reviewboard/admin/middleware.py
    reviewboard/accounts/forms.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/forms.py
    reviewboard/admin/management/commands/dumpdb.py
    reviewboard/admin/siteconfig.py
    reviewboard/admin/views.py
    reviewboard/accounts/backends.py
    reviewboard/admin/templatetags/rbadmintags.py
    reviewboard/accounts/views.py
    reviewboard/accounts/urls.py
    reviewboard/admin/urls.py
    reviewboard/admin/management/sites.py
    reviewboard/accounts/models.py
    reviewboard/admin/widgets.py
    reviewboard/admin/cache_stats.py
    reviewboard/accounts/admin.py
    reviewboard/admin/middleware.py
    reviewboard/accounts/forms.py
  Ignored Files:

Change Summary:

Forgot to commit before posting

Diff:

Revision 5 (+208 -203)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/backends.py
	reviewboard/accounts/forms.py
	reviewboard/accounts/models.py
	reviewboard/accounts/urls.py
	reviewboard/accounts/views.py
	reviewboard/accounts/evolutions/timezone.py
	reviewboard/admin/cache_stats.py
	10 more

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/forms.py
    reviewboard/admin/management/commands/dumpdb.py
    reviewboard/admin/siteconfig.py
    reviewboard/admin/views.py
    reviewboard/accounts/backends.py
    reviewboard/admin/templatetags/rbadmintags.py
    reviewboard/accounts/evolutions/timezone.py
    reviewboard/accounts/urls.py
    reviewboard/admin/urls.py
    reviewboard/admin/management/sites.py
    reviewboard/accounts/models.py
    reviewboard/admin/widgets.py
    reviewboard/admin/cache_stats.py
    reviewboard/accounts/admin.py
    reviewboard/accounts/views.py
    reviewboard/admin/middleware.py
    reviewboard/accounts/forms.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/forms.py
    reviewboard/admin/management/commands/dumpdb.py
    reviewboard/admin/siteconfig.py
    reviewboard/admin/views.py
    reviewboard/accounts/backends.py
    reviewboard/admin/templatetags/rbadmintags.py
    reviewboard/accounts/evolutions/timezone.py
    reviewboard/accounts/urls.py
    reviewboard/admin/urls.py
    reviewboard/admin/management/sites.py
    reviewboard/accounts/models.py
    reviewboard/admin/widgets.py
    reviewboard/admin/cache_stats.py
    reviewboard/accounts/admin.py
    reviewboard/accounts/views.py
    reviewboard/admin/middleware.py
    reviewboard/accounts/forms.py
  Ignored Files:

Ship it!

```
One last thing, then ship it.
```
reviewboard/admin/urls.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Same comments about the urlpatterns in this file.
```

Status:: Completed
Change Summary:: Pushed to master (4db0867).