Add infinite scroll for commits in the new review request UI.

Review Request #4411 — Created Aug. 8, 2013 and submitted

Information

Review Board
master

Reviewers

Add infinite scroll for commits in the new review request UI.

This change makes it so scrolling to within 50px of the bottom of the list of
commits in the New Review Request page will automatically load another page.
This shows the little "Loading..." spinner at the top, but is otherwise pretty
seamless.
- Loaded many pages of commits.
- Connected a repo with only a small number of commits, and saw that it stopped
  loading once I hit the bottom.
Description From Last Updated

This would need to be apply(), otherwise arguments would become just the first parameter to the parent render(). Best to …

chipx86chipx86

This is too long. Also, can we make a constant for the 50? I don't like it buried in the …

chipx86chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/newReviewRequest/views/commitsView.js
        reviewboard/static/rb/js/resources/collections/repositoryCommitsCollection.js
        reviewboard/static/rb/js/views/collectionView.js
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/newReviewRequest/views/commitsView.js
        reviewboard/static/rb/js/resources/collections/repositoryCommitsCollection.js
        reviewboard/static/rb/js/views/collectionView.js
    
    
  2. 
      
chipx86
  1. 
      
  2. This would need to be apply(), otherwise arguments would become just the first parameter to the parent render().
    
    Best to avoid using apply and arguments, though, since render() doesn't need any arguments, and using arguments at all will cause some performance penalties for the compilation of the function in most JavaScript VMS.
  3. This is too long.
    
    Also, can we make a constant for the 50? I don't like it buried in the code.
  4. 
      
david
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/newReviewRequest/views/commitsView.js
        reviewboard/static/rb/js/resources/collections/repositoryCommitsCollection.js
        reviewboard/static/rb/js/views/collectionView.js
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/newReviewRequest/views/commitsView.js
        reviewboard/static/rb/js/resources/collections/repositoryCommitsCollection.js
        reviewboard/static/rb/js/views/collectionView.js
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/newReviewRequest/views/commitsView.js
        reviewboard/static/rb/js/resources/collections/repositoryCommitsCollection.js
        reviewboard/static/rb/js/views/collectionView.js
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/newReviewRequest/views/commitsView.js
        reviewboard/static/rb/js/resources/collections/repositoryCommitsCollection.js
        reviewboard/static/rb/js/views/collectionView.js
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (e3b2883).
Loading...