Summary

Make issue_opened and issue_status more consistent.

Review Request #4404 — Created Aug. 7, 2013 and submitted Aug. 7, 2013, 5:25 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

2984

Depends On

Reviewers

Groups

reviewboard

People

Description

Make issue_opened and issue_status more consistent.

If a user creates a comment with an issue, and later removes that issue before
publishing, we end up in a weird state where the issue_status is still 'O' but
issue_opened is false. This change fixes it to clear out issue_status when
removing the issue_opened bit.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (120 > 79 characters)	reviewbot	Aug. 7, 2013, 3:33 p.m.
Col: 49 E702 multiple statements on one line (semicolon)	reviewbot	Aug. 7, 2013, 3:33 p.m.
Col: 80 E501 line too long (120 > 79 characters)	reviewbot	Aug. 7, 2013, 3:38 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/webapi/tests.py
    reviewboard/webapi/resources.py
  Ignored Files:

reviewboard/webapi/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (120 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 49
 E702 multiple statements on one line (semicolon)
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/webapi/tests.py
    reviewboard/webapi/resources.py
  Ignored Files:

Diff:

Revision 2 (+17)

Show changes

	reviewboard/webapi/resources.py
	reviewboard/webapi/tests.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/webapi/tests.py
    reviewboard/webapi/resources.py
  Ignored Files:

reviewboard/webapi/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (120 > 79 characters)
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/webapi/tests.py
    reviewboard/webapi/resources.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (1c98b2c).

reviewboard/webapi/tests.py (Diff revision 1)

reviewboard/webapi/tests.py (Diff revision 1)

reviewboard/webapi/tests.py (Diff revision 2)