Summary

Fix ValueError when the user enters a bad cache host.

Review Request #4402 — Created Aug. 7, 2013 and submitted Aug. 7, 2013, 2:03 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-1.7.x

Bugs

3049

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix ValueError when the user enters a bad cache host.

If the user enters a cache hostname which doesn't split properly, it makes the
admin site unavailable. This is because the cache stats code was just blindly
trying to unpack the values without any error handling. I've updated it to
cache this case, log, and continue.

Testing Done

Expand All
Collapse All

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/admin/cache_stats.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/admin/cache_stats.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (56d28dd).