Summary

Send the base commit ID for a change to the server when using Git.

Review Request #4398 — Created Aug. 5, 2013 and submitted Aug. 13, 2013, 2:26 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

smacleod

Description

Send the base commit ID for a change to the server when using Git.

When uploading a change to a new enough Review Board server, the base
commit ID is sent along in the request. This ID/revision represents the
upstream commit that the diff (or its parent diff) applies to. It can be
used by the server to communicate with hosting services that otherwise
do not work solely with the content found in the diffs.

Testing Done

Tested with my Review Board change, and saw the base commit ID in the
database.

Posted this change on reviews.reviewboard.org, which doesn't have the
base commit ID support, and it didn't fail.

Issues

Description	From	Last Updated
Col: 33 E126 continuation line over-indented for hanging indent	reviewbot	Aug. 5, 2013, 7:07 p.m.

Fix it!

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbtools/commands/post.py
    rbtools/utils/diffs.py
    rbtools/api/resource.py
    rbtools/clients/git.py
  Ignored Files:

rbtools/commands/post.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 33
 E126 continuation line over-indented for hanging indent
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    rbtools/commands/post.py
    rbtools/utils/diffs.py
    rbtools/api/resource.py
    rbtools/clients/git.py
  Ignored Files:

So you updated the git client, but the diff_changelist/diff_between_revisions/diff implementations for all the other clients also need to be changed to return dictionaries.

chipx86 Aug. 12, 2013, 11:43 a.m.

The function that decides which of these to call is smart enough to handle the old tuple form.

That said, I'll update, and I'll also fix post-review, which wasn't updated.

(I guess I pushed at one point. Didn't mean to do that. I'll fix in a separate review request.)

Review Board 7.0 alpha 0 (dev)

Send the base commit ID for a change to the server when using Git.

Information

Reviewers

Status: Closed (submitted)

rbtools/commands/post.py (Diff revision 1)