Summary

Fix Plastic's usage of self._options.

Review Request #4395 — Created Aug. 5, 2013 and submitted Aug. 5, 2013, 5:15 p.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

3044

Depends On

Reviewers

Groups

rbtools

People

Description

Fix Plastic's usage of self._options.

When the plastic client is creating a diff for a branch, it tries to set the
'branch' field in the options object so that it will get set properly in the
review request. This broke when we refactored the command-line options to be
able to have different options for each rbt command.

Testing Done

Issues

Description	From	Last Updated
Can be consolidated to: if not getattr(self.options, 'branch', None):	chipx86	Aug. 5, 2013, 4:12 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbtools/clients/plastic.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    rbtools/clients/plastic.py
  Ignored Files:

rbtools/clients/plastic.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can be consolidated to:

if not getattr(self.options, 'branch', None):
```

Diff:

Revision 2 (+2 -2)

Show changes

rbtools/clients/plastic.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbtools/clients/plastic.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    rbtools/clients/plastic.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (3bd0c7f).

rbtools/clients/plastic.py (Diff revision 1)