Fix Plastic's usage of self._options.
Review Request #4395 — Created Aug. 5, 2013 and submitted
| Information | |
|---|---|
| david | |
| RBTools | |
| master | |
| 3044 | |
| Reviewers | |
| rbtools | |
Fix Plastic's usage of self._options. When the plastic client is creating a diff for a branch, it tries to set the 'branch' field in the options object so that it will get set properly in the review request. This broke when we refactored the command-line options to be able to have different options for each rbt command.
| Description | From | Last Updated |
|---|---|---|
|
Can be consolidated to: if not getattr(self.options, 'branch', None): |
 chipx86
|
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: rbtools/clients/plastic.py Ignored Files:
-
-
rbtools/clients/plastic.py (Diff revision 1) Can be consolidated to: if not getattr(self.options, 'branch', None):
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/clients/plastic.py Ignored Files:
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/clients/plastic.py Ignored Files: