Summary

Allow FileAttachment.file to store longer file paths.

Review Request #4394 — Created Aug. 5, 2013 and submitted Aug. 5, 2013, 4:16 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-1.6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Allow FileAttachment.file to store longer file paths.

FileField, by default, limits to 100 characters, which was barely enough
as it was. With the new change for prepending a hash, this was
suffocating.

We now set that max length to 512 characters. While that's far smaller
than the max path length of most file systems, it should be enough for
our use, and is far more than what users have had in the past.

Testing Done

Verified that the column had a max length of 512 after evolving.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/evolutions/file_attachment_file_max_length_512.py
    reviewboard/attachments/models.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/evolutions/file_attachment_file_max_length_512.py
    reviewboard/attachments/models.py
  Ignored Files:

Ship it!

```
Ship It!
```

Review Board 7.0 alpha 0 (dev)

Allow FileAttachment.file to store longer file paths.

Information

Reviewers

Status: Closed (submitted)