Allow FileAttachment.file to store longer file paths.

Review Request #4394 — Created Aug. 5, 2013 and submitted

Information

Review Board
release-1.6.x

Reviewers

Allow FileAttachment.file to store longer file paths.

FileField, by default, limits to 100 characters, which was barely enough
as it was. With the new change for prepending a hash, this was
suffocating.

We now set that max length to 512 characters. While that's far smaller
than the max path length of most file systems, it should be enough for
our use, and is far more than what users have had in the past.
Verified that the column had a max length of 512 after evolving.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/attachments/evolutions/__init__.py
        reviewboard/attachments/evolutions/file_attachment_file_max_length_512.py
        reviewboard/attachments/models.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/attachments/evolutions/__init__.py
        reviewboard/attachments/evolutions/file_attachment_file_max_length_512.py
        reviewboard/attachments/models.py
      Ignored Files:
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed