Summary

Fix HTTP requests on Python 2.5.x.

Review Request #4375 — Created Aug. 2, 2013 and submitted Aug. 3, 2013, 3:19 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-1.7.x

Bugs

3043

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix HTTP requests on Python 2.5.x.

Python 2.5.x doesn't understand that all HTTP 2xx status codes are
successful responses and not errors. This causes problems when using
Python 2.5 and services like GitHub, which may return 2xx codes.

This fix is not needed for Python 2.6+.

Testing Done

Sent the patch to a user, and they verified it fixed their problem.

Tested with my Python 2.7 install, and had no issues fetching from
GitHub.

Expand All
Collapse All

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/hostingsvcs/service.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/hostingsvcs/service.py
  Ignored Files:

Ship it!

```
Ship It!
```

Review Board 7.0 alpha 0 (dev)

Fix HTTP requests on Python 2.5.x.

Information

Reviewers

Status: Closed (submitted)