Fix alignment and appearance of boxes in review requests.

Review Request #4364 — Created July 29, 2013 and submitted — Latest diff uploaded

Information

Review Board
master

Reviewers

Fix alignment and appearance of boxes in review requests.

We have a bunch of stacked boxes in our review request and diffviewer pages.
When we introduced the new look for diffs, it became apparent to me that we had
some alignment and bleeding issues in these pages:
- Diff boxes were 2px less wide than anything else.
- Diff boxes didn't have a shadow.
- The collapse buttons for reviews and change descriptions weren't vertically
  centered.
- Change descriptions have a kind of wacky structure where there are two
  different elements with the "changedesc" class. This meant that we had some
  bleeding of the background color outside of the border (which I only
  noticed when zoomed way in).

 

    Loading...