Summary

Generate Retina versions of uploaded image thumbnails.

Review Request #4363 — Created July 28, 2013 and submitted July 28, 2013, 11:17 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Generate Retina versions of uploaded image thumbnails.

When fetching the thumbnail for an image, we now generate both a
standard and Retina version of the image. retina.js will display the
appropriate one when rendering. This adds a bit of nice crispness to any
thumbnails with fine detail, such as screenshots.

Testing Done

Tested with Firefox and Chrome with a Retina display and without.

On the Retina display, I saw a lot more detail than before.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/attachments/mimetypes.py
    reviewboard/reviews/models.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/attachments/mimetypes.py
    reviewboard/reviews/models.py
  Ignored Files:

What happens if you upload an image smaller than the retina thumbnail?

chipx86 July 28, 2013, 11:15 p.m.

It just displays as their actual size. Nothing special. I have some 16x16 and 32x32 images in my test review request and they're still the (scaled up) 16x16 and 32x32 like they would have been before.

Ship it!

```
Ship It!
```

Status:: Completed