Add a retina version of our logo.
Review Request #4360 — Created July 25, 2013 and submitted
Add a retina version of our logo. There's now the old standard version of our logo (which has been replaced with a slightly cleaner version), and a Retina version. We're using retinajs for this. It gives us a handy .less .at2x() macro, which will attempt to fetch a @2x version of an image and apply it using a background-image. This will be used for icons going forward. It also will look for any <img> tags with a data-at2x= attribute, and fetch those versions instead. The one annoying thing is that this will attempt to fetch a @2x of every <img> we have now. This will be less of a problem as we move to having retina versions and using spritesheets in more locations, though we may have to work around it for file attachments.
Saw the new icon on a Retina display. Looked pretty. Temporarily disabled Retina icon support and saw the old icon.
| Description | From | Last Updated |
|---|---|---|
|
Where is this file from? Can you add some header comment with source/version/etc? |
 david
|
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/lib/css/retina.less reviewboard/static/rb/images/logo.png reviewboard/static/rb/images/logo@2x.png reviewboard/static/lib/js/retina.js reviewboard/static/rb/css/common.less reviewboard/templates/base/branding.html
-
-
reviewboard/static/lib/js/retina.js (Diff revision 1) Where is this file from? Can you add some header comment with source/version/etc?
Change Summary:
* Added a copyright header to retina.js * Moved retina.less into the rb/css/ directory, since otherwise, any images loaded will be local to the lib/css directory.
Diff: |
Revision 2 (+186 -2) |
|---|
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/images/logo.png reviewboard/static/rb/css/retina.less reviewboard/static/lib/js/retina.js reviewboard/static/rb/css/common.less reviewboard/static/rb/images/logo@2x.png reviewboard/templates/base/branding.html
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/images/logo.png reviewboard/static/rb/css/retina.less reviewboard/static/lib/js/retina.js reviewboard/static/rb/css/common.less reviewboard/static/rb/images/logo@2x.png reviewboard/templates/base/branding.html
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/lib/css/retina.less reviewboard/static/rb/images/logo.png reviewboard/static/rb/images/logo@2x.png reviewboard/static/lib/js/retina.js reviewboard/static/rb/css/common.less reviewboard/templates/base/branding.html