Fix the display of draft comments in review UIs.

Review Request #4356 — Created July 23, 2013 and submitted

Information

Review Board
release-1.7.x

Reviewers

Fix the display of draft comments in review UIs.

Draft comments from other users were being shown in review UIs, since we
weren't filtering out based on whether the current user had the ability
to see the comment.

This affected the image review UI, and anything else using the default
get_serialized_comments function.
Created a draft comment, and then viewed the page in another browser
without logging in.

Before this change, I could see the comment. After the change, I could not.

Unit tests pass.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/ui/base.py
        reviewboard/reviews/ui/image.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/reviews/ui/base.py
        reviewboard/reviews/ui/image.py
      Ignored Files:
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...