Add views and tests for the post-commit portion of the new review request UI.
Review Request #4355 — Created July 22, 2013 and submitted
Add views and tests for the post-commit portion of the new review request UI. This change adds a view to orchestrate creation of post-commit review requests. It presents a commit browsing UI that allows users to choose a branch and see the commit history from that branch tip, and then select a commit and create the review request from it. This is not yet consumed anywhere except js-tests, since the main new review request UI change is coming later.
- Ran unit tests. - Used this with my other pending changes.
We pull out model above and reuse it a bit, but we use repository.branches even more. We should pull out …
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/tests/postCommitViewTests.js reviewboard/static/rb/js/newReviewRequest/views/postCommitView.js reviewboard/static/rb/js/newReviewRequest/models/postCommitModel.js
Can you point me to an up-to-date screenshot? It'd help me see how this all fits together.
reviewboard/static/rb/js/newReviewRequest/views/postCommitView.js (Diff revision 1)
We pull out model above and reuse it a bit, but we use repository.branches even more. We should pull out branches too.