• 
      

    Add views and tests for the post-commit portion of the new review request UI.

    Review Request #4355 — Created July 22, 2013 and submitted

    Information

    Review Board
    master

    Reviewers

    Add views and tests for the post-commit portion of the new review request UI.
    
    This change adds a view to orchestrate creation of post-commit review requests.
    It presents a commit browsing UI that allows users to choose a branch and see
    the commit history from that branch tip, and then select a commit and create the
    review request from it.
    
    This is not yet consumed anywhere except js-tests, since the main new review
    request UI change is coming later.
    
    - Ran unit tests.
    - Used this with my other pending changes.
    Description From Last Updated

    We pull out model above and reuse it a bit, but we use repository.branches even more. We should pull out …

    chipx86chipx86
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          reviewboard/settings.py
        Ignored Files:
          reviewboard/static/rb/js/newReviewRequest/views/tests/postCommitViewTests.js
          reviewboard/static/rb/js/newReviewRequest/views/postCommitView.js
          reviewboard/static/rb/js/newReviewRequest/models/postCommitModel.js
      
      
    2. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
          reviewboard/settings.py
        Ignored Files:
          reviewboard/static/rb/js/newReviewRequest/views/tests/postCommitViewTests.js
          reviewboard/static/rb/js/newReviewRequest/views/postCommitView.js
          reviewboard/static/rb/js/newReviewRequest/models/postCommitModel.js
      
      
    2. 
        
    chipx86
    1. Can you point me to an up-to-date screenshot? It'd help me see how this all fits together.
      1. Relatively up to date screenshots are on /r/4215/
    2. Show all issues
      We pull out model above and reuse it a bit, but we use repository.branches even more. We should pull out branches too.
    3. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (53dd66e).