Summary

Combine all our icons into a spritesheet.

Review Request #4351 — Created July 20, 2013 and submitted July 24, 2013, 12:32 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

~~4350~~

Reviewers

Groups

reviewboard

People

Description

Combine all our icons into a spritesheet.

This spritesheet contains a good chunk of the artwork Review Board makes
use of. It speeds up load and render time, since we get to replace 26
file downloads with 1.

Some images were thrown out, such as the icons for certain widgets in
the admin UI that weren't really necessary, and the dropdown triangle on
the action menus.

In a few cases, logic or style changes had to be made to work with the
new class names and icon divs. The only cases where things differ is
where we had some pretty bad alignment choices from way back when on a
couple elements, and they're now fixed. (Pencil on the summary being one
example.)

This work will make it easier for us to add retina icons in time.

Testing Done

Looked at every icon that was used in every place it was used in the UI.
Everything looked the same.

Tested all the interactive icons that toggle, such as starring,
expanding, collapsing. They all behaved as expected.

I didn't attach screenshots because, visually, nothing has changed
(except for a couple icon alignments that were always off-by-1 or so).

Issues

Description	From	Last Updated
Col: 17 E127 continuation line over-indented for visual indent	reviewbot	July 20, 2013, 10:46 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/admin/widgets.py
    reviewboard/settings.py
    reviewboard/diffviewer/templatetags/difftags.py
    reviewboard/reviews/datagrids.py
  Ignored Files:
    reviewboard/templates/admin/admin_widget.html
    reviewboard/static/rb/images/rss.png
    reviewboard/static/rb/css/icons.less
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/css/dashboard.less
    reviewboard/static/rb/js/views/collapsableBoxView.js
    reviewboard/static/rb/images/collapse-review.png
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/images/db-add.png
    reviewboard/static/rb/js/views/commentIssueBarView.js
    reviewboard/templates/admin/widgets/w-repositories.html
    reviewboard/static/rb/js/views/reviewReplyEditorView.js
    reviewboard/templates/reviews/review_request_box.html
    reviewboard/static/rb/images/diff-expand-header.png
    reviewboard/templates/reviews/comment_issue.html
    reviewboard/static/rb/images/star_off.png
    reviewboard/static/rb/images/delete.png
    reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js
    reviewboard/static/rb/images/diff-expand-above.png
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/templates/diffviewer/view_diff.html
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/images/shipit.png
    reviewboard/static/rb/images/edit.png
    reviewboard/templates/reviews/star.html
    reviewboard/templates/admin/widgets/w-actions.html
    reviewboard/static/rb/images/icons.png
    reviewboard/static/rb/images/expand-review.png
    reviewboard/static/rb/images/disabled.png
    reviewboard/static/rb/images/shipit_checkmark.png
    reviewboard/templates/diffviewer/diff_file_fragment.html
    reviewboard/static/rb/images/diff-collapse.png
    reviewboard/static/rb/images/diff-expand-below.png
    reviewboard/static/rb/js/views/tests/fileAttachmentThumbnailViewTests.js
    reviewboard/static/rb/images/comment-shipit-small.png
    reviewboard/static/rb/images/comment-draft-small.png
    reviewboard/static/rb/images/star_on.png
    reviewboard/static/rb/images/open_issue.png
    reviewboard/static/rb/images/dropdown.png
    reviewboard/static/rb/images/closed_issue.png
    reviewboard/templates/reviews/review_detail.html
    reviewboard/static/rb/images/convo.png
    reviewboard/static/rb/images/expand.png
    reviewboard/static/rb/js/common.js
    reviewboard/templates/reviews/review_request_actions_secondary.html
    reviewboard/templates/base.html
    reviewboard/templates/reviews/dashboard_entry.html
    reviewboard/templates/extensions/action_dropdown.html
    reviewboard/static/rb/js/views/screenshotThumbnailView.js
    reviewboard/static/rb/images/tick.png
    reviewboard/static/rb/images/diff-expand-all.png
    reviewboard/static/rb/images/comment-small.png
    reviewboard/templates/diffviewer/expand_link.html
    reviewboard/static/rb/css/admin-dashboard.less
    reviewboard/static/rb/js/admin.js
    reviewboard/static/rb/images/collapse.png

reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 17
 E127 continuation line over-indented for visual indent
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/admin/widgets.py
    reviewboard/settings.py
    reviewboard/diffviewer/templatetags/difftags.py
    reviewboard/reviews/datagrids.py
  Ignored Files:
    reviewboard/templates/admin/admin_widget.html
    reviewboard/static/rb/images/rss.png
    reviewboard/static/rb/css/icons.less
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/css/dashboard.less
    reviewboard/static/rb/js/views/collapsableBoxView.js
    reviewboard/static/rb/images/collapse-review.png
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/images/db-add.png
    reviewboard/static/rb/js/views/commentIssueBarView.js
    reviewboard/templates/admin/widgets/w-repositories.html
    reviewboard/static/rb/js/views/reviewReplyEditorView.js
    reviewboard/templates/reviews/review_request_box.html
    reviewboard/static/rb/images/diff-expand-header.png
    reviewboard/templates/reviews/comment_issue.html
    reviewboard/static/rb/images/star_off.png
    reviewboard/static/rb/images/delete.png
    reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js
    reviewboard/static/rb/images/diff-expand-above.png
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/templates/diffviewer/view_diff.html
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/images/shipit.png
    reviewboard/static/rb/images/edit.png
    reviewboard/templates/reviews/star.html
    reviewboard/templates/admin/widgets/w-actions.html
    reviewboard/static/rb/images/icons.png
    reviewboard/static/rb/images/expand-review.png
    reviewboard/static/rb/images/disabled.png
    reviewboard/static/rb/images/shipit_checkmark.png
    reviewboard/templates/diffviewer/diff_file_fragment.html
    reviewboard/static/rb/images/diff-collapse.png
    reviewboard/static/rb/images/diff-expand-below.png
    reviewboard/static/rb/js/views/tests/fileAttachmentThumbnailViewTests.js
    reviewboard/static/rb/images/comment-shipit-small.png
    reviewboard/static/rb/images/comment-draft-small.png
    reviewboard/static/rb/images/star_on.png
    reviewboard/static/rb/images/open_issue.png
    reviewboard/static/rb/images/dropdown.png
    reviewboard/static/rb/images/closed_issue.png
    reviewboard/templates/reviews/review_detail.html
    reviewboard/static/rb/images/convo.png
    reviewboard/static/rb/images/expand.png
    reviewboard/static/rb/js/common.js
    reviewboard/templates/reviews/review_request_actions_secondary.html
    reviewboard/templates/base.html
    reviewboard/templates/reviews/dashboard_entry.html
    reviewboard/templates/extensions/action_dropdown.html
    reviewboard/static/rb/js/views/screenshotThumbnailView.js
    reviewboard/static/rb/images/tick.png
    reviewboard/static/rb/images/diff-expand-all.png
    reviewboard/static/rb/images/comment-small.png
    reviewboard/templates/diffviewer/expand_link.html
    reviewboard/static/rb/css/admin-dashboard.less
    reviewboard/static/rb/js/admin.js
    reviewboard/static/rb/images/collapse.png

Ship it!

```
Ship It!
```

Status:: Completed