Allow the use of icon class names instead of image URLs in places.

Review Request #4350 — Created July 20, 2013 and submitted

Information

Djblets
master

Reviewers

Allow the use of icon class names instead of image URLs in places.

The datagrid columns and inlineEditor now accept class names
representing icons for column and edit icons. These can be used instead
of URLs, for applications that use spritesheets.
Tested with an accompanying Review Board change that makes use of spritesheets.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        djblets/datagrid/grids.py
      Ignored Files:
        djblets/datagrid/templates/datagrid/listview.html
        djblets/datagrid/templates/datagrid/column_header.html
        djblets/media/js/jquery.gravy.js
        djblets/media/css/datagrid.css
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        djblets/datagrid/grids.py
      Ignored Files:
        djblets/datagrid/templates/datagrid/listview.html
        djblets/datagrid/templates/datagrid/column_header.html
        djblets/media/js/jquery.gravy.js
        djblets/media/css/datagrid.css
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (c1e4d05)
Loading...