Amazon S3 support for file store

Review Request #4333 — Created July 16, 2013 and submitted

Information

Review Board

Reviewers

It seems that the Amazon S3 support for file storage is broken. It is likely that this is due to the changes in Amazon side. Right now the default AWS SDK for Python is boto which is already supported by django-storages. it only requires to specify a different backend.

This will add a new dependency to reviewboard in order to support Amazon S3. Apart from django-storages, boto package is also required.

Note: I needed to uninstall the botocore package which was also installed in my system. It seems there was a conflict with boto.
Apply the patch. Install django-storages and boto with pip (also uninstall botocore which I had installed). Configure an S3 bucket with subdomain path. Create a new request and upload an screenshot. The request is created and the image is placed in the specified bucket. 

The test has been done and works with ReviewBoard 1.6.3 and ReviewBoard 1.7.11
Description From Last Updated

'S3BotoStorage' imported but unused

reviewbotreviewbot

Col: 10 E241 multiple spaces after ':'

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/admin/checks.py
        reviewboard/admin/siteconfig.py
      Ignored Files:
    
    
  2. reviewboard/admin/siteconfig.py (Diff revision 1)
     
     
    Col: 10
     E241 multiple spaces after ':'
    
  3. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/admin/checks.py
        reviewboard/admin/siteconfig.py
      Ignored Files:
    
    
  2. reviewboard/admin/checks.py (Diff revision 1)
     
     
     'S3BotoStorage' imported but unused
    
  3. 
      
chipx86
  1. Ship It!
  2. 
      
KA
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (ce1e0c2)
Loading...