Add a commit selector view.

Review Request #4322 — Created July 11, 2013 and submitted

Information

Review Board
master

Reviewers

Add a commit selector view.

This is used by the new new review request UI for creating requests from
committed revisions. This handles the basic functionality of displaying a list
of commits and triggering a 'create' event when one is clicked (or navigating to
the review request if one already exists).

There's a little bit more on my todo list for this, namely:
- Providing some visual indication when there's already a review request.
- Using the API pagination to provide infinite scroll.
Used this in my post-commit UI.
Description From Last Updated

Should be able to just put this in the events table.

chipx86chipx86

Can you document all the functions in these files?

chipx86chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/settings.py
      Ignored Files:
        reviewboard/static/rb/js/newReviewRequest/views/commitView.js
        reviewboard/static/rb/js/newReviewRequest/views/commitsView.js
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/settings.py
      Ignored Files:
        reviewboard/static/rb/js/newReviewRequest/views/commitView.js
        reviewboard/static/rb/js/newReviewRequest/views/commitsView.js
    
    
  2. 
      
chipx86
  1. 
      
  2. What goes in here?
    1. This is styled with CSS to have a spinner.
  3. Should be able to just put this in the events table.
  4. Can you document all the functions in these files?
  5. 
      
david
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/settings.py
      Ignored Files:
        reviewboard/static/rb/js/newReviewRequest/views/commitView.js
        reviewboard/static/rb/js/newReviewRequest/views/commitsView.js
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/settings.py
      Ignored Files:
        reviewboard/static/rb/js/newReviewRequest/views/commitView.js
        reviewboard/static/rb/js/newReviewRequest/views/commitsView.js
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (69dbbc9).
Loading...