Summary

Add a commit selector view.

Review Request #4322 — Created July 11, 2013 and submitted July 21, 2013, 8:52 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Add a commit selector view.

This is used by the new new review request UI for creating requests from
committed revisions. This handles the basic functionality of displaying a list
of commits and triggering a 'create' event when one is clicked (or navigating to
the review request if one already exists).

There's a little bit more on my todo list for this, namely:
- Providing some visual indication when there's already a review request.
- Using the API pagination to provide infinite scroll.

Testing Done

Used this in my post-commit UI.

Issues

Description	From	Last Updated
Should be able to just put this in the events table.	chipx86	July 21, 2013, 4:55 p.m.
Can you document all the functions in these files?	chipx86	July 21, 2013, 4:55 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/settings.py
  Ignored Files:
    reviewboard/static/rb/js/newReviewRequest/views/commitView.js
    reviewboard/static/rb/js/newReviewRequest/views/commitsView.js

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/settings.py
  Ignored Files:
    reviewboard/static/rb/js/newReviewRequest/views/commitView.js
    reviewboard/static/rb/js/newReviewRequest/views/commitsView.js

reviewboard/static/rb/js/newReviewRequest/views/commitView.js (Diff revision 1)
```
What goes in here?
```
1. david July 21, 2013, 4:59 p.m.
  This is styled with CSS to have a spinner.
reviewboard/static/rb/js/newReviewRequest/views/commitView.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Should be able to just put this in the events table.
```

reviewboard/static/rb/js/newReviewRequest/views/commitView.js (Diff revision 1)

The issue has been resolved. Show all issues

Can you document all the functions in these files?

Diff:

Revision 2 (+101)

Show changes

	reviewboard/settings.py
	reviewboard/static/rb/js/newReviewRequest/views/commitView.js
	reviewboard/static/rb/js/newReviewRequest/views/commitsView.js

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/settings.py
  Ignored Files:
    reviewboard/static/rb/js/newReviewRequest/views/commitView.js
    reviewboard/static/rb/js/newReviewRequest/views/commitsView.js

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/settings.py
  Ignored Files:
    reviewboard/static/rb/js/newReviewRequest/views/commitView.js
    reviewboard/static/rb/js/newReviewRequest/views/commitsView.js

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (69dbbc9).