Add views and tests for a branches selector.
Review Request #4321 — Created July 11, 2013 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| master | |
| Reviewers | |
| reviewboard | |
Add views and tests for a branches selector. This change adds views to show a RepositoryBranchesCollection using a <select> tag. This is used in the new post-commit review request creator.
- Ran unit tests. - Used this in my post-commit UI.
| Description | From | Last Updated |
|---|---|---|
|
I think you can just register this event in the events {} table. It'll do the binding and unbinding for … |
 chipx86
|
|
|
Oh also, can you add some docs for functions? |
chipx86
|
|
|
You can combine these. |
chipx86
|
|
|
These are going to make jshint very sad. I think we need to not name things "default" and find a … |
chipx86
|
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/tests/branchesViewTests.js reviewboard/static/rb/js/newReviewRequest/views/branchView.js reviewboard/static/rb/js/newReviewRequest/views/branchesView.js
-
-
reviewboard/static/rb/js/newReviewRequest/views/branchesView.js (Diff revision 1) I think you can just register this event in the events {} table. It'll do the binding and unbinding for you. -
reviewboard/static/rb/js/newReviewRequest/views/branchesView.js (Diff revision 1) You can combine these.
-
These are going to make jshint very sad. I think we need to not name things "default" and find a non-keyword name, like "isDefault". Can you run jshint on this change and make sure it's happy?
-
Is this necessary? I wouldn't expect the above to be async, unless the browser's really handling the selected changes in the next event loop?
-
-
reviewboard/static/rb/js/newReviewRequest/views/branchesView.js (Diff revision 1) Oh also, can you add some docs for functions?
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/resources/collections/tests/repositoryBranchesCollectionTests.js reviewboard/static/rb/js/resources/models/tests/repositoryBranchModelTests.js reviewboard/static/rb/js/resources/models/repositoryBranchModel.js reviewboard/static/rb/js/newReviewRequest/views/branchView.js reviewboard/static/rb/js/resources/models/validateDiffModel.js reviewboard/static/rb/js/newReviewRequest/views/tests/branchesViewTests.js reviewboard/static/rb/js/resources/models/reviewRequestModel.js reviewboard/static/rb/js/newReviewRequest/views/branchesView.js
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/resources/collections/tests/repositoryBranchesCollectionTests.js reviewboard/static/rb/js/resources/models/tests/repositoryBranchModelTests.js reviewboard/static/rb/js/resources/models/repositoryBranchModel.js reviewboard/static/rb/js/newReviewRequest/views/branchView.js reviewboard/static/rb/js/resources/models/validateDiffModel.js reviewboard/static/rb/js/newReviewRequest/views/tests/branchesViewTests.js reviewboard/static/rb/js/resources/models/reviewRequestModel.js reviewboard/static/rb/js/newReviewRequest/views/branchesView.js
Diff: |
Revision 3 (+156 -6)
|
|---|
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/resources/collections/tests/repositoryBranchesCollectionTests.js reviewboard/static/rb/js/resources/models/tests/repositoryBranchModelTests.js reviewboard/static/rb/js/resources/models/repositoryBranchModel.js reviewboard/static/rb/js/newReviewRequest/views/branchView.js reviewboard/static/rb/js/resources/models/validateDiffModel.js reviewboard/static/rb/js/newReviewRequest/views/tests/branchesViewTests.js reviewboard/static/rb/js/resources/models/reviewRequestModel.js reviewboard/static/rb/js/newReviewRequest/views/branchesView.js
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/resources/collections/tests/repositoryBranchesCollectionTests.js reviewboard/static/rb/js/resources/models/tests/repositoryBranchModelTests.js reviewboard/static/rb/js/resources/models/repositoryBranchModel.js reviewboard/static/rb/js/newReviewRequest/views/branchView.js reviewboard/static/rb/js/resources/models/validateDiffModel.js reviewboard/static/rb/js/newReviewRequest/views/tests/branchesViewTests.js reviewboard/static/rb/js/resources/models/reviewRequestModel.js reviewboard/static/rb/js/newReviewRequest/views/branchesView.js
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/tests/branchesViewTests.js reviewboard/static/rb/js/newReviewRequest/views/branchView.js reviewboard/static/rb/js/newReviewRequest/views/branchesView.js