Summary

Add JavaScript for validating diff files.

Review Request #4320 — Created July 11, 2013 and submitted July 20, 2013, 10:52 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Add JavaScript for validating diff files.

This is the client side of the diff validation resource. To use this, one
instantiates the model, sets the repository/diff/parent diff/basedir, and calls
save(). Either the "success" or "error" callbacks in the options object passed
to save will be called, based on whether the diff parses correctly and the
source files exist.

Testing Done

- Ran unit tests.
- Used this with a number of different diffs that caused various errors.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/settings.py
  Ignored Files:
    reviewboard/static/rb/js/resources/models/validateDiffModel.js
    reviewboard/static/rb/js/resources/models/tests/validateDiffModelTests.js

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/settings.py
  Ignored Files:
    reviewboard/static/rb/js/resources/models/validateDiffModel.js
    reviewboard/static/rb/js/resources/models/tests/validateDiffModelTests.js

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (30b4b89).