Make the diff viewer prettier and cleaner.
Review Request #4317 — Created July 10, 2013 and submitted
Make the diff viewer prettier and cleaner. This polishes up the look of the diff viewer a bit. The highlights include: * Removed lots of unnecessary borders, that separated content, instead relying on the backgrounds and whitespace for the separation. * Softened the colors, making the reds and greens and browns less harsh. * The borders around the chunks are now based on the color of the chunk, instead of a generic grey. * Removed a lot of the borders on the file header. The header is now one box instead of three or four. * The moved line indicators are simpler and less bulky. The font size has been reduced, the complex background is gone, they have more consistent padding, and they are now flush up against each other. * The table borders are rounded, making them more consistent with the other boxy bits of the UI.
Tested with a bunch of diffs, in Firefox and Chrome. Tested that navigation/anchors still worked. Unit tests pass.
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: Ignored Files: reviewboard/templates/reviews/review_detail.html reviewboard/templates/diffviewer/diff_file_fragment.html reviewboard/static/rb/css/reviews.less reviewboard/static/rb/css/diffviewer.less reviewboard/templates/diffviewer/view_diff.html reviewboard/templates/diffviewer/diff_fragment_error.html reviewboard/templates/reviews/diff_comment_fragment.html reviewboard/static/rb/js/diffviewer/views/chunkHighlighterView.js
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: Ignored Files: reviewboard/templates/reviews/review_detail.html reviewboard/templates/diffviewer/diff_file_fragment.html reviewboard/static/rb/css/reviews.less reviewboard/static/rb/css/diffviewer.less reviewboard/templates/diffviewer/view_diff.html reviewboard/templates/diffviewer/diff_fragment_error.html reviewboard/templates/reviews/diff_comment_fragment.html reviewboard/static/rb/js/diffviewer/views/chunkHighlighterView.js