Summary

Adjust the way that parent revision numbers are computed for SVN.

Review Request #4316 — Created July 9, 2013 and submitted July 10, 2013, 1:23 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Adjust the way that parent revision numbers are computed for SVN.

In the get_change implementation for SVN, I was just subtracting one from the
revision number to get the parent to diff against. This works for a typical SVN
server, but I was worried that it might fall down for wacky things like GitHub's
subversion layer. I've changed it to use the cached parent if available, and if
not, use the next item in the log.

Testing Done

Ran unit tests

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/scmtools/svn.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/scmtools/svn.py
  Ignored Files:

Looks fine, but this seems complex enough that it should have unit tests.

david July 10, 2013, 1:04 a.m.

It's covered by the existing tests--if this broke which revision was selected as the parent, it would get a different diff (and in fact, an earlier rev of this change was broken in such a way).

chipx86 July 10, 2013, 1:11 a.m.
```
Ah, great.
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (5e2eeed).