Implement post-commit review request creation.
Review Request #4315 — Created July 9, 2013 and submitted
Implement post-commit review request creation. Our webapi already has the plumbing necessary to create post-commit reviews, and in a few previous changes I added the scmtools/hostingsvcs infrastructure for fetching the necessary data. This change bridges the gap by making update_from_commit_id do the right thing if said commit_id refers to an already committed revision on a repository that supports get_change.
- Ran unit tests. - Used this with my UI.
| Description | From | Last Updated |
|---|---|---|
|
""" on the next line. |
 chipx86
|
|
|
This is hard to understand without going into the definition. Can you use keyword arguments? Also, create_from_data saves by default. |
chipx86
|
|
|
Col: 80 E501 line too long (80 > 79 characters) |
 reviewbot
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
Can you verify this works on Python 2.5? We had a property change break a release on 2.5 recently and … |
chipx86
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
local variable 'diffset' is assigned to but never used |
reviewbot
|
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/reviews/tests.py reviewboard/reviews/models.py Ignored Files:
-
-
-
reviewboard/reviews/models.py (Diff revision 1) Food for thought: Isn't it possible that the SCMTool may be able to give us a summary and description intelligently without us having to parse? Instead of parsing this here, can Commit just store summary and message fields, and allow them to be set separately, but default to parsing them? Either way, might be nice to have Commit own this logic here.
-
reviewboard/reviews/models.py (Diff revision 1) This is hard to understand without going into the definition. Can you use keyword arguments? Also, create_from_data saves by default.
-
reviewboard/reviews/tests.py (Diff revision 1) Can you verify this works on Python 2.5? We had a property change break a release on 2.5 recently and I want to be 100% sure.
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/tests.py reviewboard/scmtools/core.py reviewboard/reviews/models.py Ignored Files:
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/reviews/tests.py reviewboard/scmtools/core.py reviewboard/reviews/models.py Ignored Files: -
reviewboard/reviews/models.py (Diff revision 2) local variable 'diffset' is assigned to but never used
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/tests.py reviewboard/scmtools/core.py reviewboard/reviews/models.py Ignored Files:
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/tests.py reviewboard/reviews/models.py Ignored Files: