Summary

Add a "supports post commit" flag to SCMTool and HostingService.

Review Request #4314 — Created July 9, 2013 and submitted July 10, 2013, 1:22 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Add a "supports post commit" flag to SCMTool and HostingService.

This adds a flag that we can access to know when we're able to create
post-commit reviews.

Testing Done

Issues

Description	From	Last Updated
Mind making these alphabetical? The other supports_* here are alphabetical right now, so might as well.	chipx86	July 10, 2013, 12:57 a.m.
Can you add docstrings?	chipx86	July 10, 2013, 1:02 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	July 10, 2013, 1:09 a.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/hostingsvcs/github.py
    reviewboard/scmtools/svn.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/core.py
    reviewboard/hostingsvcs/service.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/hostingsvcs/github.py
    reviewboard/scmtools/svn.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/core.py
    reviewboard/hostingsvcs/service.py
  Ignored Files:

reviewboard/hostingsvcs/service.py (Diff revision 1)

The issue has been resolved. Show all issues

Mind making these alphabetical? The other supports_* here are alphabetical right now, so might as well.

reviewboard/scmtools/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you add docstrings?
```

Diff:

Revision 2 (+21 -2)

Show changes

	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/service.py
	reviewboard/scmtools/core.py
	reviewboard/scmtools/models.py
	reviewboard/scmtools/svn.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/hostingsvcs/github.py
    reviewboard/scmtools/svn.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/core.py
    reviewboard/hostingsvcs/service.py
  Ignored Files:

reviewboard/scmtools/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/hostingsvcs/github.py
    reviewboard/scmtools/svn.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/core.py
    reviewboard/hostingsvcs/service.py
  Ignored Files:

Diff:

Revision 3 (+21 -2)

Show changes

	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/service.py
	reviewboard/scmtools/core.py
	reviewboard/scmtools/models.py
	reviewboard/scmtools/svn.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/hostingsvcs/github.py
    reviewboard/scmtools/svn.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/core.py
    reviewboard/hostingsvcs/service.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/hostingsvcs/github.py
    reviewboard/scmtools/svn.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/core.py
    reviewboard/hostingsvcs/service.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (c430271).