Add a "supports post commit" flag to SCMTool and HostingService.

Review Request #4314 — Created July 9, 2013 and submitted

Information

Review Board
master

Reviewers

Add a "supports post commit" flag to SCMTool and HostingService.

This adds a flag that we can access to know when we're able to create
post-commit reviews.

 
Description From Last Updated

Mind making these alphabetical? The other supports_* here are alphabetical right now, so might as well.

chipx86chipx86

Can you add docstrings?

chipx86chipx86

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/hostingsvcs/github.py
        reviewboard/scmtools/svn.py
        reviewboard/scmtools/models.py
        reviewboard/scmtools/core.py
        reviewboard/hostingsvcs/service.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/hostingsvcs/github.py
        reviewboard/scmtools/svn.py
        reviewboard/scmtools/models.py
        reviewboard/scmtools/core.py
        reviewboard/hostingsvcs/service.py
      Ignored Files:
    
    
  2. 
      
chipx86
  1. 
      
  2. reviewboard/hostingsvcs/service.py (Diff revision 1)
     
     
     
     
     
    Mind making these alphabetical? The other supports_* here are alphabetical right now, so might as well.
  3. reviewboard/scmtools/models.py (Diff revision 1)
     
     
    Can you add docstrings?
  4. 
      
david
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/hostingsvcs/github.py
        reviewboard/scmtools/svn.py
        reviewboard/scmtools/models.py
        reviewboard/scmtools/core.py
        reviewboard/hostingsvcs/service.py
      Ignored Files:
    
    
  2. reviewboard/scmtools/models.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (80 > 79 characters)
    
  3. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/hostingsvcs/github.py
        reviewboard/scmtools/svn.py
        reviewboard/scmtools/models.py
        reviewboard/scmtools/core.py
        reviewboard/hostingsvcs/service.py
      Ignored Files:
    
    
  2. 
      
david
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/hostingsvcs/github.py
        reviewboard/scmtools/svn.py
        reviewboard/scmtools/models.py
        reviewboard/scmtools/core.py
        reviewboard/hostingsvcs/service.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/hostingsvcs/github.py
        reviewboard/scmtools/svn.py
        reviewboard/scmtools/models.py
        reviewboard/scmtools/core.py
        reviewboard/hostingsvcs/service.py
      Ignored Files:
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (c430271).
Loading...