Make RB.ReviewRequest and RB.Diff somewhat more suited to creation.

Review Request #4306 — Created July 8, 2013 and submitted

Information

Review Board
master

Reviewers

Make RB.ReviewRequest and RB.Diff somewhat more suited to creation.

This change makes it easier to use RB.ReviewRequest and RB.Diff for creating new
objects on the server.

 
Description From Last Updated

Blank line after var statements.

chipx86chipx86

Up to you, but you can use _.super(this).toJSON.apply(...) now.

chipx86chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/models/diffModel.js
        reviewboard/static/rb/js/models/reviewRequestModel.js
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/models/diffModel.js
        reviewboard/static/rb/js/models/reviewRequestModel.js
    
    
  2. 
      
chipx86
  1. 
      
  2. Blank line after var statements.
  3. Up to you, but you can use _.super(this).toJSON.apply(...) now.
  4. 
      
david
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/models/diffModel.js
        reviewboard/static/rb/js/models/reviewRequestModel.js
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/models/diffModel.js
        reviewboard/static/rb/js/models/reviewRequestModel.js
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (40cc4d8).
Loading...