Summary

Make RB.ReviewRequest and RB.Diff somewhat more suited to creation.

Review Request #4306 — Created July 8, 2013 and submitted July 8, 2013, 10:50 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Make RB.ReviewRequest and RB.Diff somewhat more suited to creation.

This change makes it easier to use RB.ReviewRequest and RB.Diff for creating new
objects on the server.

Testing Done

Issues

Description	From	Last Updated
Blank line after var statements.	chipx86	July 8, 2013, 9:57 p.m.
Up to you, but you can use _.super(this).toJSON.apply(...) now.	chipx86	July 8, 2013, 9:57 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    reviewboard/static/rb/js/models/diffModel.js
    reviewboard/static/rb/js/models/reviewRequestModel.js

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
  Ignored Files:
    reviewboard/static/rb/js/models/diffModel.js
    reviewboard/static/rb/js/models/reviewRequestModel.js

reviewboard/static/rb/js/models/reviewRequestModel.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line after var statements.
```
reviewboard/static/rb/js/models/reviewRequestModel.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Up to you, but you can use _.super(this).toJSON.apply(...) now.
```

Diff:

Revision 2 (+46 -3)

Show changes

	reviewboard/static/rb/js/models/diffModel.js
	reviewboard/static/rb/js/models/reviewRequestModel.js

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    reviewboard/static/rb/js/models/diffModel.js
    reviewboard/static/rb/js/models/reviewRequestModel.js

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
  Ignored Files:
    reviewboard/static/rb/js/models/diffModel.js
    reviewboard/static/rb/js/models/reviewRequestModel.js

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (40cc4d8).