Add a centralized list of API error codes.
Review Request #4305 — Created July 7, 2013 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| master | |
| Reviewers | |
| reviewboard | |
Add a centralized list of API error codes. Right now we don't use the API error codes very much from our frontend code, but I'm expecting that to change as we make things more dynamic. This adds a centralized list of them so we don't sprinkle constants everywhere.
Ran js-tests, used the codes in my new review request rewrite.
| Description | From | Last Updated |
|---|---|---|
|
=== |
 chipx86
|
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: Ignored Files: reviewboard/static/rb/js/models/diffModel.js reviewboard/static/rb/js/models/baseResourceModel.js
-
Seems fine, but I'm wondering if we should just make this its own object. That would let us shorten all references quite a bit.
-
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/utils/apiErrors.js reviewboard/static/rb/js/models/diffModel.js
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: Ignored Files: reviewboard/static/rb/js/models/diffModel.js reviewboard/static/rb/js/models/baseResourceModel.js