Summary

Add a centralized list of API error codes.

Review Request #4305 — Created July 7, 2013 and submitted July 8, 2013, 10:42 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Add a centralized list of API error codes.

Right now we don't use the API error codes very much from our frontend code, but
I'm expecting that to change as we make things more dynamic. This adds a
centralized list of them so we don't sprinkle constants everywhere.

Testing Done

Ran js-tests, used the codes in my new review request rewrite.

Issues

Description	From	Last Updated
===	chipx86	July 8, 2013, 9:54 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    reviewboard/static/rb/js/models/diffModel.js
    reviewboard/static/rb/js/models/baseResourceModel.js

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
  Ignored Files:
    reviewboard/static/rb/js/models/diffModel.js
    reviewboard/static/rb/js/models/baseResourceModel.js

Seems fine, but I'm wondering if we should just make this its own object. That would let us shorten all references quite a bit.

reviewboard/static/rb/js/models/diffModel.js (Diff revision 1)
The issue has been resolved. Show all issues
```
===
```

Diff:

Revision 2 (+41 -1)

Show changes

	reviewboard/settings.py
	reviewboard/static/rb/js/models/diffModel.js
	reviewboard/static/rb/js/utils/apiErrors.js

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/settings.py
  Ignored Files:
    reviewboard/static/rb/js/utils/apiErrors.js
    reviewboard/static/rb/js/models/diffModel.js

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/settings.py
  Ignored Files:
    reviewboard/static/rb/js/utils/apiErrors.js
    reviewboard/static/rb/js/models/diffModel.js

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (932b2e3).