Enhance RB.Diff to be able to create new diffs.
Review Request #4303 — Created July 7, 2013 and submitted
Enhance RB.Diff to be able to create new diffs. The existing diff model didn't do very much, and was really meant for dealing with existing diffs. This change adds some attributes and methods that allow it to be used to create new diffs.
Used this in another change to create a diff from javascript.
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: Ignored Files: reviewboard/static/rb/js/models/diffModel.js
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: Ignored Files: reviewboard/static/rb/js/models/diffModel.js
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: Ignored Files: reviewboard/static/rb/js/models/diffModel.js
Review request changed
- Change Summary:
-
That's really weird...I saw the RR data in the draft...
- Summary:
-
Enhance RB.Diff to be able to create new diffs.
- Description:
-
+ Enhance RB.Diff to be able to create new diffs.
+ + The existing diff model didn't do very much, and was really meant for dealing
+ with existing diffs. This change adds some attributes and methods that allow it + to be used to create new diffs. - Testing Done:
-
+ Used this in another change to create a diff from javascript.
- Branch:
-
master
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: Ignored Files: reviewboard/static/rb/js/models/diffModel.js
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: Ignored Files: reviewboard/static/rb/js/models/diffModel.js