• 
      

    Fix key bindings for the diff viewer.

    Review Request #4300 — Created July 6, 2013 and submitted

    Information

    Review Board
    master

    Reviewers

    Fix key bindings for the diff viewer.
    
    Key bindings didn't always work, due to where they were registered.
    They're now registered on the document instead of the element, as they
    used to be before the rewrite.
    
    On top of that, the key binding code now filters out any keys pressed on
    input or textarea elements.
    Tested various keys on the diff viewer and while focused on inputs and
    textareas.
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
        Ignored Files:
          reviewboard/static/rb/js/utils/keyBindingUtils.js
      
      
    2. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
        Ignored Files:
          reviewboard/static/rb/js/utils/keyBindingUtils.js
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed