Fix up all the diff viewer anchor code.
Review Request #4296 — Created July 6, 2013 and submitted
Fix up all the diff viewer anchor code. The diff viewer anchor code was in a semi-working state. There were still calls to the now-removed 'gotoAnchor', which errored out, and there was a hacky global function for the individual DiffReviewableViews to scroll anchors. Now the views handle all anchor click events. DiffReviewableView triggers events when the file header or a chunk is clicked, and DiffViewerPageView reacts to that. The PageView also handles all clicks from the index that comes before the diff.
Tested all anchors manually. Unit tests pass.
| Description | From | Last Updated |
|---|---|---|
|
Should this call e.preventDefault()? |
 david
|
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: Ignored Files: reviewboard/templates/diffviewer/diff_file_fragment.html reviewboard/templates/diffviewer/changeindex_entry.html reviewboard/templates/diffviewer/diff_fragment_error.html reviewboard/templates/diffviewer/changeindex.html reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js
-
-
reviewboard/static/rb/js/pages/views/diffViewerPageView.js (Diff revision 1) Should this call e.preventDefault()?
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: Ignored Files: reviewboard/templates/diffviewer/diff_file_fragment.html reviewboard/templates/diffviewer/changeindex_entry.html reviewboard/templates/diffviewer/diff_fragment_error.html reviewboard/templates/diffviewer/changeindex.html reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js