Summary:

timezone string limited to 20 char whereas some timezones are greater than 20

Review Request #4230 — Created June 11, 2013 and submitted June 21, 2013, 11:49 p.m.

Information
Owner:	delyn
Repository:	Review Board
Branch:	1.7.6
Bugs:	3005
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

timezone is declared 20char long in models.py or django-evolution script whereas some timezones are greater
America/Argentina/Buenos_Aires is the longest => 30 chars

this issue can also be seen in current master branch

Testing Done

$ ./reviewboard/manage.py evolve --hint --execute
$ mysql -u reviewboard -p -D reviewboard -e "desc accounts_profile;" |grep timezone
timezone	varchar(30)	YES		NULL

Issues

Description	From	Last Updated
Col: 62 W291 trailing whitespace	reviewbot	June 11, 2013, 8:29 a.m.

Fix it!

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/accounts/evolutions/__init__.py
    reviewboard/accounts/evolutions/timezone_length_30.py
    reviewboard/accounts/models.py
  Ignored Files:

reviewboard/accounts/evolutions/timezone_length_30.py (Diff revision 1)
Show all issues
```
Col: 62
 W291 trailing whitespace
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (ee9b33d)