Remove a bunch of the review-related globals.

Review Request #4227 — Created June 10, 2013 and submitted

Information

Review Board
master

Reviewers

Remove a bunch of the review-related globals.

We used to have a bunch of globals for various bits of state, like the
review request URL, whether or not we can edit, the bug tracker URL,
etc. These have been removed, in favor of attributes on the new objects.
Most of these weren't even in use anymore.
Played around with the UI a bit and tested the affected code paths. Didn't
see any problems.

Unit tests all pass.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/templates/reviews/review_flags.js
        reviewboard/templates/js/tests.html
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/static/rb/js/views/reviewBoxListView.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
        reviewboard/templates/reviews/review_detail.html
        reviewboard/static/rb/js/views/reviewDialogView.js
        reviewboard/templates/reviews/ui/base.html
        reviewboard/static/rb/js/models/reviewRequestModel.js
        reviewboard/static/rb/js/views/commentDialogView.js
        reviewboard/templates/reviews/reviewable_base.html
    
    
  2. 
      
chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/templates/reviews/review_detail.html
        reviewboard/templates/js/tests.html
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/templates/reviews/review_flags.js
        reviewboard/static/rb/js/views/reviewBoxListView.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
        reviewboard/templates/diffviewer/view_diff.html
        reviewboard/static/rb/js/views/reviewDialogView.js
        reviewboard/templates/reviews/ui/base.html
        reviewboard/static/rb/js/models/reviewRequestModel.js
        reviewboard/static/rb/js/views/commentDialogView.js
        reviewboard/templates/reviews/reviewable_base.html
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed