Grab additional data for various resource models.

 






 

 


  Review Request #4223
  —
  Created June 8, 2013 and submitted 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Grab additional data for various resource models.

These resource models take advantage of expandedFields to get some
related objects. These can be used to render additional details for
these objects.

This is a requirement for the upcoming review dialog rewrite.

 








  


 
 

  
Unit test pass.

The review dialog change made use of this new data.

 







 









 





  








 









 






  

 








 














 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/settings.py
  Ignored Files:
    reviewboard/static/rb/js/models/screenshotCommentModel.js
    reviewboard/static/rb/js/models/tests/diffCommentModelTests.js
    reviewboard/static/rb/js/models/fileAttachmentCommentModel.js
    reviewboard/static/rb/js/models/diffCommentModel.js
    reviewboard/static/rb/js/models/tests/fileAttachmentCommentModelTests.js
    reviewboard/static/rb/js/models/fileDiffModel.js
    reviewboard/static/rb/js/models/screenshotModel.js
    reviewboard/static/rb/js/models/tests/screenshotCommentModelTests.js
    reviewboard/static/rb/js/models/tests/fileDiffModelTests.js
    reviewboard/static/rb/js/models/tests/screenshotModelTests.js


    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




chipx86




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...