Summary

Port reviewForm to Backbone.js.

Review Request #4206 — Created June 5, 2013 and discarded June 8, 2013, 6:35 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Port reviewForm to Backbone.js.

This moves reviewForm over to RB.ReviewDialogView. The logic is the same
as reviewForm, so no nice refactoring here. Just more work to get rid of
reviews.js.

Testing Done

Tested the Review dialog from the Review action button and the Edit Review
draft banner button.

Issues

Description	From	Last Updated
dlg isn't defined as a var	david	June 8, 2013, 3:24 p.m.
"buttons" isn't defined as a var	david	June 8, 2013, 3:24 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/settings.py
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/static/rb/js/views/draftReviewBannerView.js

Fix it!

chipx86 June 8, 2013, 6:35 p.m.

Meant to take this change down. It's been completely replaced.

reviewboard/static/rb/js/views/reviewDialogView.js (Diff revision 1)
An issue was opened. Show all issues
```
dlg isn't defined as a var
```
reviewboard/static/rb/js/views/reviewDialogView.js (Diff revision 1)
An issue was opened. Show all issues
```
"buttons" isn't defined as a var
```

Status: Discarded

Change Summary:

Replaced by /r/4224/