Actually support the url_name parameter in NavigationBarHook.
Review Request #4186 — Created May 28, 2013 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-1.7.x | |
| Reviewers | |
| reviewboard | |
Actually support the url_name parameter in NavigationBarHook. The docstring for this hook claimed that you could initialize it with a URL name, and have it do the reverse lookup. This was a lie. I've implemented this functionality.
- Used this in an extension I've been working on. - Ran unit tests.
-
Mind writing a unit test?
-
Description: |
|
|||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
|||||||||||||||||||||||||||
Diff: |
Revision 2 (+30) |
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/templatetags/rb_extensions.py reviewboard/extensions/tests.py Ignored Files:
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/templatetags/rb_extensions.py Ignored Files: