Actually support the url_name parameter in NavigationBarHook.

Review Request #4186 — Created May 28, 2013 and submitted

david
Review Board
release-1.7.x
reviewboard
Actually support the url_name parameter in NavigationBarHook.

The docstring for this hook claimed that you could initialize it with a URL
name, and have it do the reverse lookup. This was a lie. I've implemented this
functionality.
- Used this in an extension I've been working on.
- Ran unit tests.
Description From Last Updated

One statement?

chipx86chipx86

ha-ha

quad
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/extensions/templatetags/rb_extensions.py
      Ignored Files:
    
    
  2. 
      
chipx86
  1. Mind writing a unit test?
  2. One statement?
  3. 
      
david
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/extensions/templatetags/rb_extensions.py
        reviewboard/extensions/tests.py
      Ignored Files:
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (21d7294).
Loading...