Summary

Actually support the url_name parameter in NavigationBarHook.

Review Request #4186 — Created May 28, 2013 and submitted May 30, 2013, 6:32 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-1.7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Actually support the url_name parameter in NavigationBarHook.

The docstring for this hook claimed that you could initialize it with a URL
name, and have it do the reverse lookup. This was a lie. I've implemented this
functionality.

Testing Done

- Used this in an extension I've been working on.
- Ran unit tests.

Issues

Description	From	Last Updated
One statement?	chipx86	May 30, 2013, 12:34 a.m.
ha-ha	QU quad	June 5, 2013, 11:24 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/extensions/templatetags/rb_extensions.py
  Ignored Files:

```
Mind writing a unit test?
```
reviewboard/extensions/templatetags/rb_extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
One statement?
```

Description:

		Actually support the url_name parameter in NavigationBarHook.

		The docstring for this hook claimed that you could initialize it with a URL
~		name, and have it do the reverse lookup. This was a lie.
~
	~	name, and have it do the reverse lookup. This was a lie. I've implemented this
	~	functionality.
-		I've implemented this functionality, and used it in an extension I've been
-		working on.

Testing Done:

	+	Used this in an extension I've been working on.
	+	Ran unit tests.

Diff:

Revision 2 (+30)

Show changes

	reviewboard/extensions/tests.py
	reviewboard/extensions/templatetags/rb_extensions.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/extensions/templatetags/rb_extensions.py
    reviewboard/extensions/tests.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.7.x (21d7294).

Fix it!

reviewboard/extensions/templatetags/rb_extensions.py (Diff revision 2)
An issue was opened. Show all issues
```
ha-ha
```