Move diff fragment loading into DiffFragmentQueueView.

Review Request #4180 — Created May 27, 2013 and submitted

Information

Review Board
master

Reviewers

Move diff fragment loading into DiffFragmentQueueView.

Diff fragment loading has been moved out of reviews.js and into a helper
object. The review form and review boxes lists both instantiate this and
use it to batch load diff fragments one file at a time.
Tested with both diff comments on the reviews page, and in the review form
dialog.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/settings.py
      Ignored Files:
        reviewboard/static/rb/js/views/tests/diffFragmentQueueViewTests.js
        reviewboard/static/rb/js/views/reviewBoxListView.js
        reviewboard/templates/reviews/review_detail.html
        reviewboard/static/rb/js/reviews.js
        reviewboard/templates/reviews/review_draft_inline_form.html
        reviewboard/static/rb/js/views/diffFragmentQueueView.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...