Fix action event handling on the review UI page.

Review Request #4170 — Created May 25, 2013 and submitted

Information

Review Board
master

Reviewers

Fix action event handling on the review UI page.

The review UI page didn't have the new #review_request div around it,
which prevented action registration from working. It's now added.

On top of this, the success handler has been removed for file attachment
uploading, since the new objects will just respond to events instead and
do the right thing.
Tested that menus opened correctly again.

Tested a few different actions (including file upload and closing), which
worked.

Tested that uploading a file through the menu item didn't cause a JavaScript
error anymore.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/templates/reviews/ui/base.html
        reviewboard/templates/reviews/review_request_dlgs.html
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (ced53c9)
Loading...