Summary

Fix the upload dialogs on the review UI pages.

Review Request #4169 — Created May 25, 2013 and submitted May 25, 2013, 5:45 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-1.7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix the upload dialogs on the review UI pages.

The upload dialogs didn't contain the Django forms needed to populate
the on-screen forms, due to not using make_review_request_context. This
function (which hopefully we can kill in the future) has been moved into
reviewboard.reviews.context (to prevent a circular dependency) and is
now used in the review UI rendering code.

Testing Done

Tested clicking Add File when reviewing an image. The dialog no longer
appeared empty.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/ui/base.py
  Ignored Files:

```
Looks like this is missing context.py
```

Change Summary:

Added the missing context.py.

Diff:

Revision 2 (+49 -44)

Show changes

	reviewboard/reviews/context.py
	reviewboard/reviews/views.py
	reviewboard/reviews/ui/base.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/ui/base.py
    reviewboard/reviews/context.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (593ae91)