Create a base Differ class and move some centralized stuff into it.

Review Request #4164 — Created May 25, 2013 and submitted

Information

Review Board
release-1.7.x

Reviewers

Create a base Differ class and move some centralized stuff into it.

The two differs now inherit from Differ. This centralizes the
"interesting line" registration, and even the interesting line header
registration.

The filetype header maps have been moved into filetypes.py.

A tiny optimization was made, which was to check the diff compat version
1 (Myers differ) first, and not second. It won't make a huge difference,
but it's silly we didn't do that before.
Unit tests pass.

Loaded several diffs without problems.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/diffviewer/filetypes.py
        reviewboard/diffviewer/tests.py
        reviewboard/diffviewer/myersdiff.py
        reviewboard/diffviewer/diffutils.py
        reviewboard/diffviewer/smdiff.py
        reviewboard/diffviewer/differ.py
        reviewboard/diffviewer/forms.py
      Ignored Files:
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (5019857)
Loading...