Yeah, this is too ugly. Creating a little "ping" API node sounds appropriate.
Improvement to post-review when using webauth
Review Request #415 — Created June 13, 2008 and discarded
|Review Board SVN (deprecated)|
Ensure that "post-review" does not try to access the login page before checking whether webauth is enabled. There is a ugly hack in the patch. Instead to trying to access a review, "post-review" should access a specific page. I still have to figure out how to create a new webapi page on the server.
This was tested on the company server that is webauth enabled.
So, I'm not sold on this just yet. I'm not sure why post-review needs something special or why urllib should be asking for the username/password when we already do. I'd much rather we integrate things on the server-side such that the existing login URL works with the webauth code. If done right, post-review won't need any special changes, the settings.WEBAUTH key won't need to exist, and the settings webapi path won't need to exist. I'm actually very reluctant to expose authentication method info in a public API call.