Improve file attachment comments in review emails.
Review Request #4149 — Created May 14, 2013 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-1.7.x | |
| Reviewers | |
| reviewboard | |
Improve file attachment comments in review emails. Comments for file attachments in review emails were kind of crummy. They'd show either the caption or the filename (unlike the web UI, which showed both). They linked to the download URL, even when there was a review UI. And finally, they wouldn't show comment thumbnails.
Set up a review and a reply and checked out the preview-email URLs.
| Description | From | Last Updated |
|---|---|---|
|
What happens if the caption is empty now? It'd look weird. |
 chipx86
|
-
-
reviewboard/templates/notifications/reply_email.html (Diff revision 1) I have a concern with using 'thumbnail' for this. The text-based extensions output a *lot* of text, and just clip it with CSS. We won't get that benefit here, so those will end up looking terrible in e-mails. I suggest we have an email_thumbnail that defaults to thumbnail, but can be overridden.
-
reviewboard/templates/notifications/reply_email.txt (Diff revision 1) What happens if the caption is empty now? It'd look weird.
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: Ignored Files: reviewboard/templates/notifications/reply_email.txt reviewboard/templates/notifications/review_email.txt reviewboard/templates/notifications/reply_email.html reviewboard/templates/notifications/review_email.html
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: Ignored Files: reviewboard/templates/notifications/reply_email.txt reviewboard/templates/notifications/review_email.html reviewboard/templates/notifications/reply_email.html reviewboard/templates/notifications/review_email.txt