Improve file attachment comment links.

Review Request #4148 — Created May 14, 2013 and submitted

Information

Review Board
release-1.7.x

Reviewers

Improve file attachment comment links.

The file attachment comments in reviews had a link which looks similar to diff
comments. The text of this link is the filename, and the destination was the
download URL.

In the case where the attachment has a review UI, we want the link target to be
the review UI instead of the download URL. This change adds that in (with the
ability for the review UI to customize the link, for example, to link to a
specific page). This also includes some code for the review UI to customize the
text of the link, for example, to list which page the comment is on.
Tested this in conjunction with our premium pdf review UI.
Description From Last Updated

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/ui/base.py
        reviewboard/reviews/models.py
      Ignored Files:
        reviewboard/templates/reviews/review_detail.html
    
    
  2. reviewboard/reviews/ui/base.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (80 > 79 characters)
    
  3. 
      
david
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/ui/base.py
        reviewboard/reviews/models.py
      Ignored Files:
        reviewboard/templates/reviews/review_detail.html
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (d99b583).
Loading...