Port the unauthenticated/existing draft Comment Dialog changes to master.

Review Request #4146 — Created May 13, 2013 and submitted

Information

Review Board
master

Reviewers

Port the unauthenticated/existing draft Comment Dialog changes to master.

This updates the Comment Dialog to slim down when unauthenticated or
when there's an existing draft, just like the recent change for 1.7.

With this change, CommentEditor now requires a ReviewRequest. Unit tests
had to be updated to account for this.

Unit tests were also added for all the new states.
Tested manually with and without drafts, and with and without being logged in.

Unit tests pass.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/views/tests/commentDialogViewTests.js
        reviewboard/static/rb/js/models/tests/commentEditorModelTests.js
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/models/reviewRequestEditorModel.js
        reviewboard/static/rb/js/views/commentDialogView.js
        reviewboard/static/rb/js/models/commentEditorModel.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...