Fix overzealous file existance caching.

Review Request #4112 — Created May 8, 2013 and submitted

Information

Review Board
release-1.7.x

Reviewers

Fix overzealous file existance caching.

File existence check caching had a flaw where, if a file didn't exist,
we'd cache that it didn't exist, but if it was later pushed and then did
exist, we'd still think it didn't.

We now only cache when it exists. If it doesn't, we don't cache, and
will check again the next time get_file_exists is called.
Unit tests pass.
Description From Last Updated

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/scmtools/tests.py
        reviewboard/scmtools/models.py
      Ignored Files:
    
    
  2. reviewboard/scmtools/tests.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (85 > 79 characters)
    
  3. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...